Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LinkButton to v2 #20029

Merged
merged 6 commits into from Apr 11, 2024
Merged

Conversation

christiancp100
Copy link
Member

What does it do?

It replaces the imports of LinkButton to use the v2 of the @strapi/design-system

Why is it needed?

To use the latest version of the LinkButton component.

How to test it?

Check that the frontend tests are passing and that the screens where there is a LinkButton it still works as before.

Related issue(s)/PR(s)

DX-1326

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 8:16am

@christiancp100 christiancp100 marked this pull request as ready for review April 4, 2024 12:08
@christiancp100 christiancp100 self-assigned this Apr 4, 2024
@christiancp100 christiancp100 added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package labels Apr 4, 2024
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy Toddlers And Tiaras GIF

@christiancp100 christiancp100 merged commit f9554a3 into v5/main Apr 11, 2024
21 of 28 checks passed
@christiancp100 christiancp100 deleted the chore/refactor-link-button-to-v2 branch April 11, 2024 09:40
@echoes-hq echoes-hq bot added the echoes/type: maintenance/refactor For work refactoring tech debt or legacy work label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants