feat(history): display new and unknown fields #20039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkaylor
added
source: core:content-manager
markkaylor
commented
Apr 4, 2024
packages/core/content-manager/admin/src/pages/EditView/components/InputRenderer.tsx
Outdated
Show resolved
Hide resolved
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 2.39 MB ℹ️ View Unchanged
|
markkaylor
commented
Apr 4, 2024
packages/core/content-manager/admin/src/pages/EditView/components/InputRenderer.tsx
Outdated
Show resolved
Hide resolved
remidej
reviewed
Apr 4, 2024
packages/core/content-manager/admin/src/history/components/VersionContent.tsx
Outdated
Show resolved
Hide resolved
packages/core/content-manager/admin/src/pages/EditView/components/InputRenderer.tsx
Outdated
Show resolved
Hide resolved
markkaylor
commented
Apr 8, 2024
packages/core/content-manager/admin/src/history/components/VersionInputRenderer.tsx
Outdated
Show resolved
Hide resolved
…unknown-attributes-fe
…unknown-attributes-fe
|
All the QA test cases look good ✅ |
…unknown-attributes-fe
remidej
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Putting this in review as a draft now since I will be off tomorrow. There is some outstanding work and I made one questionable decision that is up for discussion.
Why is it needed?
How to test it?
It should support all types including components and dynamic zones however currently for these types the value of those inputs is not displayed and they are always displayed in their empty state input. This is not caused by this PR and should be addressed in another PR.
TODO