Chore: Revert @koa/cors upgrade to 5.0.0 due to breaking cors middleware #20041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: #20033
derrickmehaffy
added
source: dependencies
derrickmehaffy
changed the title
alexandrebodin
approved these changes
Apr 4, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
exp version building: https://github.com/strapi/strapi/actions/runs/8560873294 |
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
|
Exp ver: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Reverts the upgrade made in #19921 due to #20033
Why is it needed?
CORs broken in 4.22.0 due to the @koa/cors upgrade
How to test it?
Reconfigure Strapi CORs middleware with a custom origin and ensure you can access the admin panel and fetch requests from external API
Related issue(s)/PR(s)
Fix #20033