fix: prevent empty body when cloning #20047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marc-Roig
added
source: plugin:i18n
jhoward1994
approved these changes
Apr 5, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
there is a failing unit_front content releeases test, will ask CS team if they know about it before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
An i18n middleware was faliling when trying to clone a document.
The clone request had an empty body, which was an unexpected edge case.
Fixes
Also, the content manager does not send any locale when duplicating an entry, I will create another ticket for that.