Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use object.defineProperty to mock global.fetch #20050

Merged
merged 2 commits into from Apr 5, 2024

Conversation

innerdvations
Copy link
Contributor

@innerdvations innerdvations commented Apr 5, 2024

What does it do?

fix a broken test

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@innerdvations innerdvations self-assigned this Apr 5, 2024
@innerdvations innerdvations added source: tooling Source is GitHub tooling/tests/ect pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 5, 2024
@innerdvations innerdvations changed the title tests: use spyon instead of writing to global.fetch test: use spyon instead of writing to global.fetch Apr 5, 2024
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 1:14pm

@innerdvations innerdvations changed the title test: use spyon instead of writing to global.fetch test: use object.defineProperty to mock global.fetch Apr 5, 2024
@innerdvations innerdvations merged commit 9139d4b into v5/main Apr 5, 2024
74 of 82 checks passed
@innerdvations innerdvations deleted the tests/fix-global-fetch branch April 5, 2024 13:22
@echoes-hq echoes-hq bot added the echoes/type: maintenance/testing For tests written to support improved automation QA label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: maintenance/testing For tests written to support improved automation QA pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: tooling Source is GitHub tooling/tests/ect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants