Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSO Routes #20090

Merged
merged 1 commit into from Apr 12, 2024
Merged

Fix SSO Routes #20090

merged 1 commit into from Apr 12, 2024

Conversation

christiancp100
Copy link
Member

What does it do?

It fixes the SSO routes, because it wasn't rendering the appropriate component because of a mismatch in the router.

Why is it needed?

To be able to use SSO

How to test it?

To check it in a Strapi project, make sure it is EE, and you have configured and SSO Provider. Do the login and and the logout and check it works. Check also that after doing the login the localStorage has the cookie value and the cookie value is deleted.

Related issue(s)/PR(s)

DX-1322

@christiancp100 christiancp100 added source: core:admin Source is core/admin package pr: fix This PR is fixing a bug labels Apr 11, 2024
@christiancp100 christiancp100 self-assigned this Apr 11, 2024
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

e2e tests are failing but I don't think it's caused by this PR :(

@christiancp100 christiancp100 merged commit 0d82832 into v5/main Apr 12, 2024
23 of 30 checks passed
@echoes-hq echoes-hq bot added the echoes/type: bug Effort to correct undesirable or incorrect behavior label Apr 19, 2024
@joshuaellis joshuaellis deleted the fix/sso-login branch May 1, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: bug Effort to correct undesirable or incorrect behavior pr: fix This PR is fixing a bug source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants