Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pack-up): remove from monorepo (v5) #20092

Merged
merged 3 commits into from Apr 12, 2024
Merged

chore(pack-up): remove from monorepo (v5) #20092

merged 3 commits into from Apr 12, 2024

Conversation

joshuaellis
Copy link
Member

What does it do?

  • removes pack-up from the monorepo

Why is it needed?

  • it's got it's own space to breath and live

How to test it?

Related issue(s)/PR(s)

  • resolves DX-1342

@joshuaellis joshuaellis self-assigned this Apr 11, 2024
@joshuaellis joshuaellis added source: dependencies Source is dependency problem pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 11, 2024
Convly
Convly approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see you around pack-up

image

innerdvations
innerdvations approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one less package to build 5x a day 😆

(warning: I did not QA this so make sure someone else makes sure it doesn't suddenly break the build or anything)

@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 0:31am

@joshuaellis joshuaellis force-pushed the chore/remove-pack-up branch 2 times, most recently from ada38aa to 57871be Compare April 11, 2024 14:15
@joshuaellis joshuaellis force-pushed the chore/remove-pack-up branch 2 times, most recently from 104079d to a89ae3a Compare April 12, 2024 10:20
@joshuaellis
Copy link
Member Author

@innerdvations ive had to do some changes for type fixes, therefore it should really be reviewed again, soz

innerdvations
innerdvations reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some tiny changes because I'm allergic to adding any more any to the codebase. The as gets a pass only because it would require changing the actual logic and that's for another PR another day.

@joshuaellis @innerdvations
chore: add suggestions to tighten types
4ef64b9 
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
@joshuaellis joshuaellis merged commit bc71a96 into v5/main Apr 12, 2024
80 of 84 checks passed
@joshuaellis joshuaellis deleted the chore/remove-pack-up branch April 12, 2024 12:39
@echoes-hq echoes-hq bot added echoes/type: feature/deprecation For the deprecation and removal of legacy features echoes/type: maintenance/refactor For work refactoring tech debt or legacy work and removed echoes/type: feature/deprecation For the deprecation and removal of legacy features labels Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerdvations innerdvations innerdvations approved these changes

@Convly Convly Convly approved these changes

@jhoward1994 jhoward1994 jhoward1994 approved these changes

Assignees

@joshuaellis joshuaellis

Labels
echoes/type: maintenance/refactor For work refactoring tech debt or legacy work pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies Source is dependency problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joshuaellis @innerdvations @Convly @jhoward1994