Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: contributor guide for type system concepts #20120

Merged
merged 30 commits into from Apr 19, 2024
Merged

Conversation

Convly
Copy link
Member

@Convly Convly commented Apr 15, 2024

What does it do?

Add contributor documentation for the type system concepts

How to test it?

  • got to /docs
  • run yarn install then yarn start
  • heads to the Guides > Type System > Concepts

@Convly Convly added pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: typescript Source is related to TypeScript (typings, tooling, ...) labels Apr 15, 2024
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Copy link

vercel bot commented Apr 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 1:57pm

Convly and others added 6 commits April 16, 2024 11:38
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
…gistry.mdx

Co-authored-by: Ben Irvin <ben.irvin@strapi.io>
Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jhoward1994
Copy link
Contributor

Maybe it's obvious from context but should we point out in the UID file that we're not talking about a UID attribute on a content type?

Convly and others added 8 commits April 17, 2024 10:43
…gistry.mdx

Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
…gistry.mdx

Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
…gistry.mdx

Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
Co-authored-by: Hannah Paine <151527179+hanpaine@users.noreply.github.com>
Copy link

@hanpaine hanpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@Convly Convly changed the title [Type System] Contributor Guide for Type System Concepts docs: contributor guide for type system concepts Apr 19, 2024
@Convly Convly merged commit 2d8197c into v5/main Apr 19, 2024
6 of 8 checks passed
@Convly Convly deleted the v5/tsdoc/concepts branch April 19, 2024 12:33
@echoes-hq echoes-hq bot added the echoes/type: documentation Effort spent creating and updating documentation label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/type: documentation Effort spent creating and updating documentation pr: doc This PR contributes to the documentation in this repository (READMEs or Comments) source: typescript Source is related to TypeScript (typings, tooling, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants