Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade mysql2 from 3.6.0 to 3.9.4 #20123

Merged
merged 1 commit into from Apr 16, 2024
Merged

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Apr 15, 2024

What does it do?

Upgrades the MySQL2 package from 3.6.0 to 3.9.4
Changelog: https://github.com/sidorares/node-mysql2/blob/master/Changelog.md

Why is it needed?

Related to 3 dependabot alerts to a vuln we aren't directly susceptible too however some users may hit it if they use direct queries.
Related PRs for the vuln:

How to test it?

Test against clients accepting the mysql2 package (MySQL 8+ and MariaDB 10.5+

Related issue(s)/PR(s)

N/A

@derrickmehaffy derrickmehaffy added source: dependencies Source is dependency problem pr: chore This PR contains chore tasks (cleanups, configs, tooling...) labels Apr 15, 2024
@derrickmehaffy derrickmehaffy added this to the 4.23.2 milestone Apr 15, 2024
@derrickmehaffy derrickmehaffy self-assigned this Apr 15, 2024
Copy link
Contributor

Size Change: 0 B

Total Size: 1.31 MB

ℹ️ View Unchanged
Filename Size
examples/getstarted/build/bb4d0d527bdfb161bc5a.svg 2.33 kB
examples/getstarted/build/index.html 608 B
examples/getstarted/build/main.********.js 1.3 MB
examples/getstarted/build/runtime~main.********.js 4.22 kB

compressed-size-action

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contributor-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:26pm

Copy link
Contributor

@innerdvations innerdvations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just an additional note, it's not even that we're not susceptible, it's that we don't even use any version of mysql2 directly from Strapi, it comes from the user controllable version set in their project. The only reason it's in yarn.lock is because it's in the example projects.

@innerdvations innerdvations merged commit 9f8bd63 into develop Apr 16, 2024
150 checks passed
@innerdvations innerdvations deleted the deps/upgradeMySQL2 branch April 16, 2024 13:51
@alexandrebodin alexandrebodin modified the milestones: 4.23.2, 4.24.0 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants