feat(main-nav): Main Nav refactoring, refactor the logo #20135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simotae14
added
source: core:admin
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshuaellis
reviewed
Apr 17, 2024
…rapi into feat/main-nav-refactoring-logo
joshuaellis
reviewed
Apr 18, 2024
packages/core/admin/admin/src/components/MainNav/tests/NavBrand.test.tsx
Outdated
Show resolved
Hide resolved
joshuaellis
approved these changes
Apr 18, 2024
Marc-Roig
reviewed
Apr 18, 2024
|
yes @madhurisandbhor you are right but for the moment the MainNav width in condensed mode is wrong, I am gonna work on it in another ticket, now you need just to give a look to the logo and not the wrapper |
madhurisandbhor
approved these changes
Apr 18, 2024
when you do the wrapper, can you redo the CSS of the icon, because if you do a whole wrapper you wanna add the padding to the container and then use gap for it's children imo, but for now this is fine :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In the condensed view of the Left Menu it shows the new logo. The logo is no longer a link to the home page, but just a container with an image
Why is it needed?
In the refactoring of the Main Nav we want a new home icon to have the task of connecting to the home page, while the logo must only show the image of the logo.
The Home icon will be implemented in another PR.
How to test it?
Disclaimer: the new logo is used only in the condensed view at the moment because I need to implement the components used in the Logo and in the new Home icon before implementing the new MainNav wrapper
You can find all the info and link to the figma file in the Jira ticket
Related issue(s)/PR(s)
CS-762