fix: u&p service hashes passwords #20147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Indeed can we please switch to the docsrv |
jhoward1994
approved these changes
Apr 18, 2024
jhoward1994
approved these changes
Apr 18, 2024
We're still discussing how to handle the API side of things, some parts may need to wait until Strapi 6. For now we'll go with this because it needs to be fixed ASAP, but internally we can refactor at any time to use doc service once we expose the entity id api. I do also hope we have time to use doc id for the u&p content api as well. |
echoes-hq
bot
added
echoes/type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The u&p service lost its password hashing during the deprecation migration of entity service. This adds it back.
We may actually want to switch to use document service universally here, in case there's any other logic we're missing and to avoid duplicating code.
Why is it needed?
u&p passwords aren't being hashed on registration
How to test it?
Tests have been added, but:
Related issue(s)/PR(s)
DX-1372