fix(content-manager): history service

[jhoward1994]

What does it do?

Describe the technical changes you did.

Why is it needed?

Describe the issue you are solving.

How to test it?

Provide information about the environment and the path to verify the behaviour.

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

[jhoward1994]

Hey @markkaylor

I was having trouble with content history during the bulk locale publishing stuff I'm working on. This bit of code would cause an error to be thrown from

strapi/packages/core/core/src/services/document-service/internationalization.ts

Line 47 in b9f98c5

`Invalid locale param ${params.locale} provided. Document locales must be strings.`

I'm not 100% what the best solution is here. I think the problem is that now publishing can accept multiple locales, history will intercept those calls and try and proceed with the logic below using an array of locales from the params. docService.findOne then throws as this is an invalid param.

What do you think the best idea here is?

[markkaylor]

Maybe we can just check if it's an array and skip it for now 🤷‍♂️ ? Then we can circle back to adjust the logic here to handle all bulk actions. What do you think? cc @remidej

[remidej]

I think I agree with you @markkaylor. this is a place where we need to eventually write proper tests, and we should probably be the ones to write it, so I think opting out for now in this branch should be okay

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
contributor-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 26, 2024 1:40pm

[jhoward1994]

@remidej @markkaylor

Is it okay with you both if I merge this into our feature branch and you could track this TODO in the content studio team?

I need this change to test the whole feature from the FE

[markkaylor]

Could we avoid creating a mutable variable for locale? Wouldn't this be enough?

Suggested change

	let locale = defaultLocale;
	if (documentContext.locale) {
	if (Array.isArray(documentContext.locale)) {
	// TODO calls picked from the middleware could contain an array of
	// locales. This is incompatible with our call to findOne below.
	return next();
	}
	locale = documentContext.locale;
	}
	if (Array.isArray(documentContext.locale)) {
	// TODO calls picked from the middleware could contain an array of
	// locales. This is incompatible with our call to findOne below.
	return next();
	}
	const locale = documentContext.locale || defaultLocale;