Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug delete file from AWS S3 #2135

Merged
merged 2 commits into from Oct 17, 2018
Merged

Fix bug delete file from AWS S3 #2135

merged 2 commits into from Oct 17, 2018

Conversation

xargr
Copy link
Contributor

@xargr xargr commented Oct 12, 2018

this code fixed by #1992

My PR is a:

馃悰 Bug fix #1992

Main update on the:

Fix aws s3 strapi plugin because doesn't allow us to delete file

@lauriejim lauriejim self-requested a review October 17, 2018 12:26
@lauriejim lauriejim self-assigned this Oct 17, 2018
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Oct 17, 2018
@lauriejim lauriejim added this to In progress in 3.0.0-alpha.14.4 via automation Oct 17, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.14.4 milestone Oct 17, 2018
@lauriejim lauriejim changed the title fix bug delete file from aws s3 Fix bug delete file from AWS S3 Oct 17, 2018
3.0.0-alpha.14.4 automation moved this from In progress to Reviewer approved Oct 17, 2018
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for this first contrib!
Really appreciate.

@lauriejim lauriejim merged commit a9e0e92 into strapi:master Oct 17, 2018
3.0.0-alpha.14.4 automation moved this from Reviewer approved to Done Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Unexpected key 'Key' found in params when deleting a file from S3
2 participants