Plugin settings manager dev #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/content-manager
…n/content-manager
Merge branch 'plugin/settings-manager-dev' of https://github.com/strapi/strapi into plugin/settings-manager-dev
…i into plugin/settings-manager-dev
…leftmenu active links
…pi/strapi into plugin/settings-manager-dev
…i into plugin/settings-manager-dev
Merge branch 'plugin/settings-manager-dev' of https://github.com/strapi/strapi into plugin/settings-manager-dev
Aurelsicoko
reviewed
Aug 23, 2017
| * @param messages | ||
| */ | ||
| const formatMessages = messages => reduce(messages, (result, value, key) => { | ||
| const obj = result; |
There was a problem hiding this comment.
You don't need to declare the obj variable here.
Aurelsicoko
reviewed
Aug 23, 2017
| * Dynamically generate `translationsMessages object`. | ||
| */ | ||
| const translationMessages = reduce(window.Strapi.languages, (result, language) => { | ||
| const obj = result; |
Aurelsicoko
reviewed
Aug 23, 2017
| @@ -66,12 +66,12 @@ class InputNumber extends React.Component { // eslint-disable-line react/prefer- | |||
| validate = (value) => { | |||
| let errors = []; | |||
Aurelsicoko
reviewed
Aug 23, 2017
| }; | ||
| } | ||
|
|
||
| componentWillReceiveProps(nextProps) { | ||
| if (nextProps.error !== this.props.error) { | ||
| if (isEmpty(nextProps.formErrors)) this.setState({ modal: false, loader: false }); |
There was a problem hiding this comment.
Put this line with only one if statement would be better
…pi/strapi into plugin/settings-manager-dev
|
LGTM. |
|
LGTM except that we need to remove the rule of ESLint that doesn't allow to update a function parameter... It makes no sense. |
This was referenced Mar 10, 2020
This was referenced Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.