Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve permissions policy to avoid security breach with GraphQL #2275

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Aurelsicoko
Copy link
Member

@Aurelsicoko Aurelsicoko commented Nov 6, 2018

My PR is a: 馃悰 Bug fix #1317

Main update on the: Plugin GraphQL

This PR fixes the #1317 issue. It also returns Unauthorized response for GraphQL resolvers. It was handled partially which results to a security breach that allowed to bypass the Authorization header.

@lauriejim lauriejim self-requested a review November 8, 2018 14:30
@lauriejim lauriejim self-assigned this Nov 8, 2018
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Nov 8, 2018
@lauriejim lauriejim added this to In progress in 3.0.0-alpha.14.5 via automation Nov 8, 2018
@lauriejim lauriejim added this to the 3.0.0-alpha.14.5 milestone Nov 8, 2018
3.0.0-alpha.14.5 automation moved this from In progress to Ready to merge Nov 8, 2018
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lauriejim lauriejim merged commit 5a6df75 into master Nov 8, 2018
3.0.0-alpha.14.5 automation moved this from Ready to merge to Done Nov 8, 2018
@lauriejim lauriejim deleted the fix/1317 branch November 8, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

API is response for any authorization header on GraphQL
2 participants