Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements/admin #247

Merged
merged 39 commits into from
Sep 14, 2017
Merged

Improvements/admin #247

merged 39 commits into from
Sep 14, 2017

Conversation

pierreburgy
Copy link
Member

@pierreburgy pierreburgy commented Sep 12, 2017

Major changes:

  • Remove useless files
  • Update depencies, including React Router 4
  • Use strapi-helper-plugin as framework for the admin panel
  • Improve admin style

@@ -83,8 +88,7 @@ class LeftMenuLinkContainer extends React.Component { // eslint-disable-line rea
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this would be a shorter version :

{_.map(this.links, (link, key) => <LeftMenuLink key={key} icon={link.icon} label={messages[link.label].id} destination={/${_.kebabCase(link.label)} /> )}

<div className="row">
<div className="col-md-12">
<div className="col-md-12">eiuaei
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to delete 'eiuaei'

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pierreburgy pierreburgy merged commit 58e9582 into alpha.6 Sep 14, 2017
@lauriejim lauriejim deleted the improvements/admin branch January 10, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants