Plugin content type builder dev #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'plugin/content-type-builder-dev' of https://github.com/strapi/strapi into plugin/content-type-builder-dev
…trapi into plugin/content-type-builder-dev
Merge branch 'plugin/content-type-builder-dev' of github.com:strapi/strapi into plugin/content-type-builder-dev
…trapi into plugin/content-type-builder-dev
Merge branch 'plugin/content-type-builder-dev' of github.com:strapi/strapi into plugin/content-type-builder-dev
Aurelsicoko
reviewed
Sep 25, 2017
| const notifActive = link.active ? <div className={styles.notifPoint} /> : ''; | ||
| return ( | ||
| <Link key={key} className={styles.headerLink} to={`${baseUrl}/${link.name}`} activeClassName={styles.linkActive}> | ||
| <div></div> |
There was a problem hiding this comment.
Yes, BTW it's a component from the settings-manager
Aurelsicoko
reviewed
Sep 25, 2017
| } | ||
|
|
||
| componentDidMount() { | ||
| const requiredInputs = []; |
There was a problem hiding this comment.
Still not a big fan of the use of forEach loop to populate an array.
const requiredInputs = Object.keys(this.props.sections).reduce((acc, current) => {
acc.concat(
this.props.sections[current].items
.filter(item => has(item.validations, 'required'))
.map(item => item.target)
);
return acc;
}, []);There was a problem hiding this comment.
This code doesn't exist anymore. BTW it's a component from the settings-manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.