Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Infinite loading when clearing the name of an existing role #2649

Merged
merged 2 commits into from Jan 23, 2019

Conversation

soupette
Copy link
Contributor

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the follow databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

Description:

An infinite loading was displayed when clearing the name of an existing role. This PR fixes it

@lauriejim lauriejim self-requested a review January 23, 2019 09:54
@lauriejim lauriejim self-assigned this Jan 23, 2019
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:content-manager Source is core/content-manager package labels Jan 23, 2019
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim added this to 馃懛鈥嶁檪锔廔n progress in 3.0.0-alpha.21 via automation Jan 23, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.21 milestone Jan 23, 2019
@lauriejim lauriejim merged commit 8bb1f95 into master Jan 23, 2019
3.0.0-alpha.21 automation moved this from 馃懛鈥嶁檪锔廔n progress to 馃摉Done Jan 23, 2019
@lauriejim lauriejim deleted the fix/2541 branch January 23, 2019 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
No open projects
3.0.0-alpha.21
  
馃摉Done
Development

Successfully merging this pull request may close these issues.

Infinite loader when clearing name field in role edition
2 participants