Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split content-manager setting view into tabs. #2658

Merged
merged 8 commits into from Jan 30, 2019
Merged

Split content-manager setting view into tabs. #2658

merged 8 commits into from Jan 30, 2019

Conversation

soupette
Copy link
Contributor

@soupette soupette commented Jan 20, 2019 •
edited

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin: Content-Manager

Manual testing done on the follow databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

Description:
This PR splits the content-manager setting view into tabs so the view is no lighter.
It also allows to change the textarea type to WYSIWYG directly from the content-manager so it kind of solves the #2307.

TODO:

  • Update cypress tests (They are all passing with Mongod)

@soupette
Split content-manager setting view into tabs.
7e79864 
Allow to change the textarea type so the wysiwyg can be displayed without having to set it back in the content type builder.
Fixes #2307
@derrickmehaffy
Copy link
Member

@soupette got a screenshot? 😛

@soupette
Copy link
Contributor Author

@derrickmehaffy it's still very likely to change depending on @Aurelsicoko feedback...
But you can see that I have added a way to display the wysiwyg directly from the ctm
screenshot 2019-01-20 at 12 38 53

@soupette soupette changed the title [WIP]Split content-manager setting view into tabs. Split content-manager setting view into tabs. Jan 30, 2019
@Aurelsicoko
Copy link
Member

LGTM, great work @soupette 👍

@lauriejim lauriejim self-requested a review January 30, 2019 17:03
@lauriejim lauriejim added pr: 💅 Enhancement source: core:content-manager Source is core/content-manager package labels Jan 30, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.22 milestone Jan 30, 2019
lauriejim
lauriejim approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lauriejim lauriejim merged commit 079685a into master Jan 30, 2019
@lauriejim lauriejim deleted the split-ctm-settings-view branch January 30, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim approved these changes

@Aurelsicoko Aurelsicoko Awaiting requested review from Aurelsicoko

Assignees

@soupette soupette

Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
3.0.0-alpha.22
Development

Successfully merging this pull request may close these issues.

WYSIWYG text fields not displaying as expected in production environment
4 participants
@soupette @derrickmehaffy @Aurelsicoko @lauriejim