Fix SQL query where oneWay relationship is null #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauriejim
added
pr: 馃悰 Bug fix
source: core:content-manager
lauriejim
moved this from 馃暟Waiting for classification
to 馃惪For next release
in 馃Cooking
|
I'm still seeing NULL on deep nested relations:
|
|
@greatwitenorth What is the version of strapi you use to test it ? |
|
This is alpha 20 with the specific changes done from this pull request. I can try updating to 21 today to see if that fixes anything. |
|
Yes please. And make sur you apply update of this PR. |
|
After updating to Alpha 21 and applying the patches in this update I'm now seeing empty result sets for ALL nested relations when I know for certain there's related data: Deeply nested data: Nested data: |
|
Can you give us models you use (to have the relation type and test it on our side) |
|
You can ignore my issue, after updating to alpha 22 everything seems to be working correctly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR is a:
Main update on the:
Manual testing done on the follow databases:
Description:
I fixed the SQL query that allows retrieving multiple entries through GraphQL, there was a bug when a oneWay relationship was null.