Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create new entry for models that have only relational fields #2862

Merged
merged 3 commits into from Feb 25, 2019

Conversation

soupette
Copy link
Contributor

Description:

Currently, you can't create an entry if your model only has relational fields.
This PR fixes this bug.

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix #issueNumber
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin: content-manager

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres

@derrickmehaffy
Copy link
Member

Nice one!

@lauriejim lauriejim self-assigned this Feb 21, 2019
@lauriejim lauriejim self-requested a review February 21, 2019 14:18
@lauriejim lauriejim added pr: 馃拝 Enhancement source: core:content-manager Source is core/content-manager package labels Feb 21, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.25 milestone Feb 21, 2019
Copy link
Member

@Aurelsicoko Aurelsicoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim merged commit 849795b into master Feb 25, 2019
@lauriejim lauriejim deleted the improve/ctm branch February 25, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants