Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forcefully disable package-lock generation #2906

Merged
merged 2 commits into from Mar 2, 2019
Merged

Forcefully disable package-lock generation #2906

merged 2 commits into from Mar 2, 2019

Conversation

derrickmehaffy
Copy link
Member

Description:

Forces NPM to disable automatic generation of the package-lock.json that can cause problems for projects cloned from Github or other Git related repos.

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@derrickmehaffy derrickmehaffy self-assigned this Feb 28, 2019
@lauriejim lauriejim added this to the 3.0.0-alpha.25 milestone Mar 1, 2019
@lauriejim lauriejim added pr: 馃悰 Bug fix source: core:strapi Source is core/strapi package labels Mar 1, 2019
Copy link
Member

@Aurelsicoko Aurelsicoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's a bad practice the feature seems too buggy in our case to let this file being generated on each new project.

@lauriejim lauriejim merged commit 4286987 into master Mar 2, 2019
@lauriejim lauriejim deleted the add/npmLock branch March 2, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with project cloned
3 participants