Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filters on timestamp attributes #3209

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

lauriejim
Copy link
Contributor

⚠️ We have stopped merging PRs for now to the Strapi core.


The reason is that we are developing new architecture for the admin panel and for the plugins.

This new architecture will provide stability of the Strapi core as we approach the release of Beta.

We appreciate and welcome all your contributions, but until further notice, please do not submit a PR as it will not be merged.

Furthermore, you will have to rewrite it based on the new architecture.

Description:

Filter on timestamps attributes was not available.
So I restore the filters on these attributes

My PR is a:

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@derrickmehaffy
Copy link
Member

Fix works perfect:

image

derrickmehaffy
derrickmehaffy previously approved these changes May 1, 2019
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin
Copy link
Member

@lauriejim If you are up for it, you can add a test for REST and GraphQL for this filter ;)

otherwise LGTM

alexandrebodin
alexandrebodin previously approved these changes May 2, 2019
@derrickmehaffy
Copy link
Member

you can add a test

HAHAHAHA 🤣

\o/

@alexandrebodin alexandrebodin dismissed stale reviews from derrickmehaffy and themself via 7ea0fac May 2, 2019 09:00
@lauriejim
Copy link
Contributor Author

Hello! Nop, but we will remove them because to many spec that are different for MySQL, Mongo...
So we plan to review the date layer soon. And when it will be done, we will add tests on data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't filter on created_at or updated_at (REST & GraphQL)
3 participants