Update the CONTRIBUTING GUIDE #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrebodin
requested changes
May 27, 2019
CONTRIBUTING.md
Outdated
| @@ -14,214 +8,143 @@ Strapi is an open-source project administered by [the Strapi team](https://strap | |||
|
|
|||
| Before contributing, ensure that your effort is aligned with the project's roadmap by talking to the maintainers, especially if you are going to spend a lot of time on it. Feel free to [join us on Slack](http://slack.strapi.io) if you are interested in helping us or [drop us an email](mailto:hi@strapi.io) if you are interested in working with us. | |||
There was a problem hiding this comment.
If you are interesting in helping us or working with us
CONTRIBUTING.md
Outdated
|
|
||
| If you send a pull request, please do it against the `master` branch. We are developing upcoming versions separately to ensure non-breaking changes from master to the latest stable major version. | ||
| We are using [GitHub Issues](https://github.com/strapi/strapi/issues) to manage our public bugs. We keep a close eye on this so before filling a new task try to make sure the problem doesn't already exist. |
There was a problem hiding this comment.
so before filling a new issue, try to make sur it does not already exist
CONTRIBUTING.md
Outdated
|
|
||
| [Go to the repository](https://github.com/strapi/strapi) and fork it to your own GitHub account. | ||
| **Before submitting your pull request** make sure the following requirements are done: |
There was a problem hiding this comment.
the following requirements are fullfilled
CONTRIBUTING.md
Outdated
|
|
||
| #### 3. ⏳ Installation | ||
| - You have [Node](https://nodejs.org/en/) at v8.0.0+ and [Yarn](https://yarnpkg.com/en/) at v1.2.0+. |
There was a problem hiding this comment.
I agree node v10 for now, node 11 is not an LTS it's a dev version and node 12 isn't LTS until october:
|
@renatodex Yarn is now required to contribute as we are exploiting the yarn workspaces feature to manage the monorepo |
alexandrebodin
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the CONTRIBUTING GUIDE to reflect the new development workflow.
My PR is a:
Main update on the:
Manual testing done on the following databases: