Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated deployment guide for Digital Ocean #3328

Merged
merged 2 commits into from
May 28, 2019

Conversation

davidkartuzinski
Copy link
Contributor

@davidkartuzinski davidkartuzinski commented May 27, 2019

⚠️ We have stopped merging PRs for now to the Strapi core.


The reason is that we are developing new architecture for the admin panel and for the plugins.

This new architecture will provide stability of the Strapi core as we approach the release of Beta.

We appreciate and welcome all your contributions, but until further notice, please do not submit a PR as it will not be merged.

Furthermore, you will have to rewrite it based on the new architecture.

Updated deployment guide for Digital Ocean

I corrected various issues in the guide to reflect better coding standards and ensure a better development experience.

Description:

I updated the docs to reflect and fix various permission errors, and to remove --watch from pm2 as not suitable in production. Various other changes and typos were also fix.

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix #issueNumber
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@davidkartuzinski davidkartuzinski added the source: docs Documentation changes label May 27, 2019
@davidkartuzinski davidkartuzinski self-assigned this May 27, 2019
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and we tested it thoroughly :)

docs/3.x.x/guides/deployment.md Outdated Show resolved Hide resolved
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 6e2aa3f into master May 28, 2019
@alexandrebodin alexandrebodin deleted the deployment-digital-ocean-modification branch May 28, 2019 09:27
@lauriejim lauriejim added this to the 3.0.0-beta milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants