Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint and prettier back to repo #3344

Merged
merged 6 commits into from
May 29, 2019
Merged

Add eslint and prettier back to repo #3344

merged 6 commits into from
May 29, 2019

Conversation

alexandrebodin
Copy link
Member

⚠️ We have stopped merging PRs for now to the Strapi core.


The reason is that we are developing new architecture for the admin panel and for the plugins.

This new architecture will provide stability of the Strapi core as we approach the release of Beta.

We appreciate and welcome all your contributions, but until further notice, please do not submit a PR as it will not be merged.

Furthermore, you will have to rewrite it based on the new architecture.

Description:

Adds eslint and prettier formatting with commit hooks

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix #issueNumber
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@alexandrebodin alexandrebodin added this to the 3.0.0-beta milestone May 29, 2019
@alexandrebodin alexandrebodin changed the title WIP: Add eslint and prettier back to repo Add eslint and prettier back to repo May 29, 2019
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim merged commit e08e3fe into beta May 29, 2019
@lauriejim lauriejim deleted the tech/lint branch May 29, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:strapi Source is core/strapi package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants