Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status code handler to health checks #3426

Merged
merged 2 commits into from Jun 11, 2019

Conversation

alexandrebodin
Copy link
Member

Description of what you did:

When strapi is behind a proxy (nginx) you will get a 502 which isn't right now and displays an error message

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.4 milestone Jun 11, 2019
@alexandrebodin alexandrebodin force-pushed the tech/handle-health-bad-status-code branch from 1c276c7 to 0e56068 Compare June 11, 2019 15:52
@alexandrebodin alexandrebodin force-pushed the tech/handle-health-bad-status-code branch from 0e56068 to 2311f7d Compare June 11, 2019 15:53
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 9d8025e into master Jun 11, 2019
@alexandrebodin alexandrebodin deleted the tech/handle-health-bad-status-code branch June 11, 2019 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants