-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New content manager schemas + wysiwyg type #3668
Conversation
For clarification this is creating a new field type instead of storing WYSIWYG in the content-manager right? |
One of the commits does that :) The rest just changes completely the format of the content manager schema storage |
Cool that's what I thought, just wanted to check to make sure I wasn't reading into things 😉 |
packages/strapi-plugin-content-manager/services/utils/configuration/metadatas.js
Outdated
Show resolved
Hide resolved
@@ -6,19 +6,5 @@ module.exports = { | |||
destroy: 'User.destroy', | |||
deleteall: 'User.destroyAll', | |||
}, | |||
attributes: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it normal to remove the default User layout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not going to use thoses classes anymore. We can define a new way to have default layouts though. We didn't really talk about that. @Aurelsicoko @soupette might need to check that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of what you did:
New content manager schemas + wysiwyg type
My PR is a:
Main update on the:
Manual testing done on the following databases: