Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New content manager schemas + wysiwyg type #3668

Merged
merged 20 commits into from
Jul 23, 2019

Conversation

alexandrebodin
Copy link
Member

Description of what you did:

New content manager schemas + wysiwyg type

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@lauriejim lauriejim added the flag: 💥 Breaking change This PR contains breaking changes and should not be merged label Jul 23, 2019
@derrickmehaffy
Copy link
Member

For clarification this is creating a new field type instead of storing WYSIWYG in the content-manager right?

@alexandrebodin
Copy link
Member Author

For clarification this is creating a new field type instead of storing WYSIWYG in the content-manager right?

One of the commits does that :) The rest just changes completely the format of the content manager schema storage

@derrickmehaffy
Copy link
Member

For clarification this is creating a new field type instead of storing WYSIWYG in the content-manager right?

Cool that's what I thought, just wanted to check to make sure I wasn't reading into things 😉

@@ -6,19 +6,5 @@ module.exports = {
destroy: 'User.destroy',
deleteall: 'User.destroyAll',
},
attributes: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal to remove the default User layout?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not going to use thoses classes anymore. We can define a new way to have default layouts though. We didn't really talk about that. @Aurelsicoko @soupette might need to check that

Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 084a913 into develop Jul 23, 2019
@alexandrebodin alexandrebodin deleted the chore/new-content-manager-schemas branch July 23, 2019 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants