Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Strapi Quickstart #3924

Merged
merged 4 commits into from Sep 11, 2019
Merged

Update Strapi Quickstart #3924

merged 4 commits into from Sep 11, 2019

Conversation

davidkartuzinski
Copy link
Contributor

Description of what you did:

Update the Strapi Quickstart:

  1. Change to yarn/npx commands (from Strapi Global Installation)
  2. Remove unnecessary steps ( no longer part of the process)
  3. Clarified some steps
  4. Removed Article link in the bottom (no longer exists)
  5. Other minor changes

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@davidkartuzinski davidkartuzinski self-assigned this Sep 9, 2019
lauriejim
lauriejim reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good waiting for the video.

alexandrebodin
alexandrebodin requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

docs/3.0.0-beta.x/getting-started/quick-start.md Show resolved Hide resolved
docs/3.0.0-beta.x/getting-started/quick-start.md Outdated Show resolved Hide resolved
docs/3.0.0-beta.x/getting-started/quick-start.md Outdated Show resolved Hide resolved
@davidkartuzinski
Copy link
Contributor Author

Just a few comments

@alexandrebodin I have resolved your comments. Thank you.

alexandrebodin
alexandrebodin approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit ae4bfb8 into strapi:master Sep 11, 2019
@alexandrebodin alexandrebodin added source: docs Documentation changes and removed type: documentation 馃摉 labels Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

@lauriejim lauriejim Awaiting requested review from lauriejim

Assignees

@davidkartuzinski davidkartuzinski

Labels
source: docs Documentation changes
Projects
None yet
Milestone
3.0.0-beta.16.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidkartuzinski @lauriejim @alexandrebodin