Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql policies fix #4008

Merged
merged 5 commits into from Sep 16, 2019

Conversation

donmasakayan
Copy link
Contributor

Old deprecated PR: #3881

Description of what you did:

Fixes three issues as outlined in this issue:
fix #3880 fix #2766

Issue 1: Inaccurate Documentation on GraphQL Policies
Issue 2: Policies not triggering for custom Mutations
Issue 3: Policies don't have ctx.state.user

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@donmasakayan donmasakayan mentioned this pull request Sep 16, 2019
13 tasks
@derrickmehaffy
Copy link
Member

Awesome 😃 Thanks for your work @donmasakayan

@alexandrebodin alexandrebodin changed the title Graphql policies fix (3.0.0-beta.16.3) Graphql policies fix Sep 16, 2019
@alexandrebodin alexandrebodin added pr: 🐛 Bug fix source: core:content-manager Source is core/content-manager package labels Sep 16, 2019
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.17 milestone Sep 16, 2019
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with GraphQL policies Resolver in String is not working in custom GraphQL
3 participants