Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graphql plugin resolverof #4040

Merged
merged 3 commits into from Sep 18, 2019
Merged

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Sep 18, 2019

Description of what you did:

Fix #4035

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexandrebodin alexandrebodin merged commit cc691c0 into master Sep 18, 2019
@alexandrebodin alexandrebodin deleted the fix/graphql-plugin-resolverof branch September 18, 2019 11:59
@avirankatzsofi
Copy link

After updating to beta.16.15, I see that any user can update any other user (given that the updating user is permitted to use updateUser). Is that intended?

@alexandrebodin
Copy link
Member Author

@avirankatzsofi do you mean user or admin ?
if you make the updateUser permission public or authenticated then sadly it will be acessible by the users having the role. There is no notion of context for those routes. if you want a user to be able to update itself you should make a custom mutation for then and those ones are mainly designed to be for administration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User mutations can be used without auth by default
3 participants