Mongoose reconnect #4315
Mongoose reconnect #4315
Conversation
This patch will restore a lost connection to MongoDB. Checked on both standalone and replica set environments. Please, put an attention that mongoose option reconnectTries doesn't have an effect on replica set. The only way to restore a connection in this case is to use Mongoose.connect call
|
@AHgPuK Thanks for this PR. Can you references some discussions (in the mongoose repo or something like that) as to why the auto reconnect isn't handle directly with mongoose ? |
First of all, it fixes MongoError: server instance pool was destroyed #4188 In case of replica set (I use a lot for my projects) mongoose tries to reconnect only few times. Perhaps during 1 minute or less. |
Make reconnectTries and reconnectInterval readable from configs
| @@ -87,17 +89,33 @@ module.exports = function(strapi) { | |||
| connectOptions.dbName = database; | |||
| connectOptions.useCreateIndex = true; | |||
| connectOptions.useUnifiedTopology = useUnifiedTopology || 'false'; | |||
| connectOptions.reconnectInterval = reconnectInterval || defaults.reconnectInterval; | |||
There was a problem hiding this comment.
the defaults are already set on line 65 (coming from strapi.config.hook.settings.mongoose)
| try { | ||
| await connect(); | ||
|
|
||
| instance.connection.on('disconnected', function() { |
There was a problem hiding this comment.
Can you please use arrow functions in this code. Don't forget to implement the reconnectTries logic too :)
There was a problem hiding this comment.
I think we should leave reconnectTries logic under the mongoose hood.
As I tried to explain I cant find a reason to stay disconnected.
If you have a scenario where a strapi project could be irresponsible forever I would change my mind.
There was a problem hiding this comment.
SImple example: a docker container. if you disconnect it should exit instead of keeping alive for eternity hence the retry counter
There was a problem hiding this comment.
It will not exit on disconnect. Too many listeners are bound including http port binding etc.
I use docker containers in production. No similar scenario.
There was a problem hiding this comment.
You are missing my point, whether you want a docker container to be killed or not is irrelevant.
What I am saying is that a user should be able to control that :) e.g retry 5 times then do sth like:
connection.on('someFinalEvent', ()= > { /* do sth */ }) or anything else the user wants to do.
|
@AHgPuK Are you going to open a new PR or sth ? |
No. Never mind. |
This patch will restore a lost connection to MongoDB.
Checked on both standalone and replica set environments.
Please, put an attention that mongoose option reconnectTries doesn't have an effect on replica set.
The only way to restore a connection in this case is to use Mongoose.connect call
Related to MongoError: server instance pool was destroyed #4188
Description of what you did:
My PR is a:
Main update on the:
Manual testing done on the following databases: