Init database layer v2 #4319
Init database layer v2 #4319
Conversation
packages/strapi-dbal/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| # Strapi database layer | |||
There was a problem hiding this comment.
Can you add the words abstraction
There was a problem hiding this comment.
We might just call it strapi-db to avoid any confusion 馃 what do you think
There was a problem hiding this comment.
Hum yes I agree!
Let's rename :)
There was a problem hiding this comment.
I would say you should expand this out to be strapi-database as all the other packages don't use short names or acronyms.
packages/strapi-plugin-settings-manager/services/SettingsManager.js
Outdated
Show resolved
Hide resolved
|
@alexandrebodin what would be the best way to test this? I take it you guys plan to drop a migration guide eventually. Is it just pulling in the dbal package and removing the hooks and tweaking the database.json? |
Yes basically rename strapi-hook-bookshelf to strapi-connector-bookshelf and set the database connector to bookshelf and reinstall the deps. Will be in a migration guide for sure. BTW this is only a develop PR not on master ;) |
alexandrebodin
force-pushed
the
chore/init-dbal
branch
from
6dd3ff3
to
cfa6ea0
Compare
alexandrebodin
force-pushed
the
chore/init-dbal
branch
from
cfa6ea0
to
66b2d4f
Compare
|
Haven't had time to test but so far looking good. |
Description of what you did:
This PR initializes the new database layer design with a new central package and moves the connectors from beeing hooks to be simple connector that will be loaded on startup.
My PR is a:
Main update on the:
Manual testing done on the following databases: