feat(plugin-users-permissions): auth email case-insensitive #442
Conversation
| @@ -32,10 +32,11 @@ module.exports = { | |||
| const isEmail = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/.test(params.identifier); | |||
|
|
|||
| // Set the identifier to the appropriate query field. | |||
| const identifier = params.identifier.toLowerCase(); | |||
There was a problem hiding this comment.
Why do you need to lowercase the identifier at this line? It should only concern the email. Also, if we do that we have to be sure that the stored email is lowercased during the registration process or that our query whatever the connector (strapi-bookshelf, strapi-mongoose) are making a query that is case-insensitive.
There was a problem hiding this comment.
The identifier is lowercased here:
d9198dd
Do you prefer to only lowercase the email?
There was a problem hiding this comment.
Yes, it's a mistake on our side. We should also remove the spaces, accents, etc by using the _.deburr() method of Lodash. But, we have to keep uppercase characters.
There was a problem hiding this comment.
ok so I'll apply lowercase only in email field.
There was a problem hiding this comment.
@lucaperret Awesome! We will be able to merge after these changes.
There was a problem hiding this comment.
Ok but how to lowercase only the email field ?
Here d9198dd I don't know if it's an email or username...
There was a problem hiding this comment.
@lucaperret You have to add this line to the register method
|
Thank you for your work @lucaperret! It's great to see active contributor like you 👍 Can you read my comment and come back to us with the necessary updates? |
|
Done |
No description provided.