Wrap tsvector attributes with coalesce before join #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where joining multiple tsvector attributes results in NULL because one of the columns contains NULL. The expected behaviour is to ignore that column instead, which is achieved by setting it to an empty string
alexandrebodin
added
pr: 馃拝 Enhancement
source: core:strapi
alexandrebodin
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Columns are now wrapped in
coalescebefore joining the tsvectors because a single NULL would result in the entire tsvector being NULL. This used to result in unexpected behaviour where a single NULL would disable searching for relations in the content-manager when using postgres as the backend.My PR is a:
Main update on the:
Manual testing done on the following databases: