Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update databases.md #4793

Merged
merged 2 commits into from Dec 23, 2019
Merged

Update databases.md #4793

merged 2 commits into from Dec 23, 2019

Conversation

Michael-Scott-PC
Copy link
Contributor

@Michael-Scott-PC Michael-Scott-PC commented Dec 21, 2019

Description of what you did:

Hello Strapi Team - running yarn create strapi-app new my-project generates a folder named "new". The "my-project" part has no effect on this command. I ran this a couple times to verify. If the intent is to a create a new folder named "my-project" I would recommend removing the word "new". - Mike

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

Hello Strapi Team - running yarn create strapi-app new my-project generates a folder named "new".  The "my-project" part has no effect on this command. I ran this a couple times to verify. If the intent is to a create a new folder named "my-project" I would recommend removing the word "new".  - Mike
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.18.3 milestone Dec 23, 2019
@alexandrebodin alexandrebodin merged commit acb5c65 into strapi:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants