Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(admin): Improve plugin name validator in install/uninstall plugin #4925

Merged
merged 1 commit into from Jan 7, 2020
Merged

chore(admin): Improve plugin name validator in install/uninstall plugin #4925

merged 1 commit into from Jan 7, 2020

Conversation

alexandrebodin
Copy link
Member

Description of what you did:

Use a better plugin name validator

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Main update on the:

  • Admin
  • Documentation
  • Framework
  • Plugin

Manual testing done on the following databases:

  • Not applicable
  • MongoDB
  • MySQL
  • Postgres
  • SQLite

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.18.4 milestone Jan 7, 2020
lauriejim
lauriejim approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 8e3e6bc into master Jan 7, 2020
@alexandrebodin alexandrebodin deleted the fix/plugin-install-params branch January 7, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauriejim lauriejim lauriejim approved these changes

Assignees
No one assigned
Labels
source: core:admin Source is core/admin package
Projects
None yet
Milestone
3.0.0-beta.18.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandrebodin @lauriejim