Front/webhooks editview #4962

virginieky · 2020-01-09T22:00:19Z

Description of what you did:

Webhook feature

Retrieve and display all webhooks as a list
Delete one or several webhooks from a list view
Enable/disable webhook from the list
Create a webhook
Edit a webhook
Test a webhook trigger and display the result

My PR is a:

💥 Breaking change
🐛 Bug fix
💅 Enhancement
🚀 New feature

Main update on the:

Admin
Documentation
Framework
Plugin

Manual testing done on the following databases:

…text

…nt/webhooks-listview

…to front/webhooks-editview

…nt/webhooks-editview

soupette · 2020-01-13T09:49:17Z

packages/strapi-admin/admin/src/components/EmptyList/Wrapper.js

+  padding: 54px 30px 30px;
+  text-align: center;
+  background-color: white;
+  p,


Can you avoid global selectors? maybe you can create components instead.

I won't create a component just to set a line-height: normal attribute. I wish it's a problem we will never have again after setting the new design system: this attribute should be set to all elements in a reset file, it's the way the entire admin should work.

For the <p/> element, the selector :first-of-type makes it non global.

I see, you are right. Regarding the reset css do you thing that this is a task we should undertake soon?
I know that we have an import of sanitize.css in the entry point of the admin do you think that we should remove it?

It's a task we should indeed undertake soon, but it may take some time to check it doesn't broke the grid :(
sanitize.css is great for some generic attributes but it seems we cannot custom it. Maybe we can replace it by our own reset rules (like button hasn't an outline, p doesn't have a margin-bottom by default, or all the ul has a list-styleattribute set tonone`, etc) based on the future design system so we're sure not to specify it each time.

packages/strapi-admin/admin/src/containers/Admin/index.js

packages/strapi-admin/admin/src/containers/SettingsPage/index.js

packages/strapi-admin/admin/src/containers/Webhooks/ListView/index.js

packages/strapi-admin/admin/src/components/Inputs/index.js

packages/strapi-admin/admin/src/components/HeadersInput/index.js

packages/strapi-admin/admin/src/components/EventInput/index.js

…nt/webhooks-editview

packages/strapi-admin/admin/src/containers/Webhooks/ListView/index.js

packages/strapi-admin/admin/src/containers/Webhooks/EditView/index.js

soupette · 2020-01-16T14:34:37Z

packages/strapi-admin/admin/src/containers/Webhooks/EditView/index.js

+    actions: headersActions,
+  };
+
+  const handleBlur = () => {


Can you reorder your functions here as well?

packages/strapi-admin/admin/src/containers/Webhooks/EditView/utils/formatData.js

packages/strapi-admin/admin/src/containers/Webhooks/EditView/utils/schema.js

codecov · 2020-01-16T17:34:53Z

Codecov Report

❗ No coverage uploaded for pull request base (features/webhooks@cc82180). Click here to learn what that means.
The diff coverage is 3.64%.

@@                 Coverage Diff                 @@
##             features/webhooks   #4962   +/-   ##
===================================================
  Coverage                     ?   9.87%           
===================================================
  Files                        ?     635           
  Lines                        ?    8634           
  Branches                     ?    1334           
===================================================
  Hits                         ?     853           
  Misses                       ?    6553           
  Partials                     ?    1228

Flag	Coverage Δ
#front	`7.51% <3.64%> (?)`
#unit	`38.42% <ø> (?)`

Impacted Files	Coverage Δ
.../admin/src/containers/Webhooks/EditView/Wrapper.js	`100% <ø> (ø)`
...ent-type-builder/admin/src/components/List/List.js	`0% <ø> (ø)`
...admin/admin/src/components/HeadersInput/Wrapper.js	`100% <ø> (ø)`
...pi-admin/admin/src/components/EmptyList/Wrapper.js	`100% <ø> (ø)`
...i-admin/admin/src/components/EventInput/Wrapper.js	`100% <ø> (ø)`
...min/admin/src/components/TriggerContainer/index.js	`50% <ø> (ø)`
...min/src/containers/Webhooks/EditView/utils/form.js	`100% <ø> (ø)`
...-admin/admin/src/components/EventInput/EventRow.js	`30% <0%> (ø)`
...nt-manager/admin/src/components/CustomTable/Row.js	`0% <0%> (ø)`
...i-admin/admin/src/components/HeadersInput/index.js	`13.04% <0%> (ø)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc82180...af578e9. Read the comment docs.

soupette · 2020-01-16T18:29:18Z

packages/strapi-admin/admin/src/containers/Webhooks/ListView/index.js

+        });
+      }
+    } catch (err) {
+      if (isMounted.current) {


Not sure this is needed here but the setShowModal(false) should be inside the isMounted condition

soupette · 2020-01-16T18:31:58Z

packages/strapi-admin/admin/src/containers/Webhooks/EditView/utils/schema.js

+
+const schema = yup.object().shape({
+  name: yup
+    .string(translatedErrors.string)


The string property does not exist in this object. Here's the corresponding file

soupette · 2020-01-16T18:36:20Z

packages/strapi-admin/admin/src/containers/Webhooks/EditView/index.js

+          method: 'GET',
+        });
+
+        if (isMounted.current) {


This is not needed here

soupette · 2020-01-16T18:38:29Z

packages/strapi-admin/admin/src/containers/Webhooks/EditView/index.js

+    try {
+      await schema.validate(modifiedData, { abortEarly: false });
+
+      if (isMounted.current) {


The isMounted logic here is not needed, we should use it when we are requesting the API

soupette · 2020-01-16T18:38:41Z

packages/strapi-admin/admin/src/containers/Webhooks/EditView/index.js

+        }
+      }
+    } catch (err) {
+      if (isMounted.current) {


Signed-off-by: Virginie Ky <virginie.ky@gmail.com>

soupette · 2020-01-17T16:52:03Z

packages/strapi-admin/admin/src/components/EventInput/index.js

+    onChange({ target: { name: inputName, value: Array.from(set) } });
+  };
+
+  console.log('yoyo');


Can you remove the console?

Signed-off-by: Virginie Ky <virginie.ky@gmail.com>

soupette

LGTM

virginieky added 30 commits December 12, 2019 17:11

ListView

4998ab1

Custom ListRow

f6dc095

ListView UI

a2a0efe

Retrieve webhooks from API with datamanager and display list from con…

ad8d8c5

…text

Merge branch 'features/webhooks' of github.com:strapi/strapi into fro…

d39c538

…nt/webhooks-listview

Data manager and hooks

3023c70

Simplify navigation

abd55da

Some comments for pr review

5c0b230

PR review apply

3226e0c

PR review apply

9c89c5f

EmptyList

7b28ebe

pr review apply

3d570a4

Switch enabled with PUT request

2f8e745

Switch UI

7578a2d

Switch id fix

72af585

Webhook delete with popup warning

6de7367

Delete all with refresh data

adc8539

Delete multiple webhooks with API

93b44ee

Edit button

7f1d3f4

EditView Setup

feaa7f0

Create Form with input text errors

dad8f80

EditView form

75a18a3

EditView UI

a094a32

Trigger states

3a00197

create webhook

b0d0c66

update webhook

942b8ce

Trigger states & update fix

ca49219

Headers delete

8f34629

Select UI

e0c6d2a

Errors states

e377afd

virginieky added 3 commits January 13, 2020 10:17

Merge branch 'front/webhooks-editview' of github.com:strapi/strapi in…

f388051

…to front/webhooks-editview

Merge branch 'features/webhooks' of github.com:strapi/strapi into fro…

fb7017c

…nt/webhooks-editview

lint fixes

0bbc414

soupette mentioned this pull request Jan 13, 2020

Webhooks ListView #4732

Closed

13 tasks

Buffetjs version

cc82180

alexandrebodin requested a review from soupette January 13, 2020 14:38

soupette suggested changes Jan 13, 2020

View reviewed changes

virginieky added 5 commits January 13, 2020 18:14

Merge branch 'features/webhooks' of github.com:strapi/strapi into fro…

e250ac8

…nt/webhooks-editview

Apply PR review

7f60f6e

PR review apply

469f07b

Apply code PR review

d78f7ed

dept exception

87a5198

virginieky requested a review from soupette January 15, 2020 17:28

virginieky added 3 commits January 16, 2020 11:00

reorder main files elements

e6b4f42

Error object for custom input

662b9fe

CTB sublist button UI fix

4add71d

soupette suggested changes Jan 16, 2020

View reviewed changes

Code review apply

84d0427

virginieky requested a review from soupette January 16, 2020 17:22

soupette suggested changes Jan 16, 2020

View reviewed changes

virginieky added 2 commits January 17, 2020 13:37

event onblur fix

27786d1

Signed-off-by: Virginie Ky <virginie.ky@gmail.com>

events input ref

e444cf0

alexandrebodin requested a review from soupette January 17, 2020 16:22

editview methods reorder

2753a66

Signed-off-by: Virginie Ky <virginie.ky@gmail.com>

soupette suggested changes Jan 17, 2020

View reviewed changes

log remove

af578e9

Signed-off-by: Virginie Ky <virginie.ky@gmail.com>

soupette approved these changes Jan 17, 2020

View reviewed changes

soupette merged commit 7ccd012 into features/webhooks Jan 17, 2020

soupette deleted the front/webhooks-editview branch January 17, 2020 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Front/webhooks editview #4962

Front/webhooks editview #4962

virginieky commented Jan 9, 2020

soupette Jan 13, 2020

virginieky Jan 13, 2020

soupette Jan 14, 2020

virginieky Jan 14, 2020

soupette Jan 16, 2020

codecov bot commented Jan 16, 2020 •

edited

soupette Jan 16, 2020

soupette Jan 16, 2020

soupette Jan 16, 2020

soupette Jan 16, 2020

soupette Jan 16, 2020

soupette Jan 17, 2020

soupette left a comment

Front/webhooks editview #4962

Front/webhooks editview #4962

Conversation

virginieky commented Jan 9, 2020

Description of what you did:

My PR is a:

Main update on the:

Manual testing done on the following databases:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jan 16, 2020 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

soupette left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 16, 2020 •

edited