removed text-transform from variable name #5296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5296 +/- ##
=======================================
Coverage 13.71% 13.71%
=======================================
Files 633 633
Lines 8685 8685
Branches 1337 1337
=======================================
Hits 1191 1191
Misses 6319 6319
Partials 1175 1175
Continue to review full report at Codecov.
|
|
Really think this should be merged :) We are just waiting for some discussion in the team ;) |
|
I completely agree this should be merged it's really confusing to have a different casing than the one the user sets! |
|
@Aurelsicoko can you jump in on this? |
|
Yes, let's do it! We should not modify the way the developer named the fields. We should not lowercase, or camelcase, or anything. Let things as they are ;) LGTM |
alexandrebodin
added
source: core:content-type-builder
|
Thanks guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
Hello There!
I was following the tutorial and realize that variable names are capitalized, which is a bit misleading.
So thought of removing that.