Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant callback argument #5371

Merged
merged 2 commits into from Mar 20, 2020
Merged

Conversation

dacre-denny
Copy link
Contributor

The cb argument is not used in the send method and was therefore removed. Ready for merge.

@codecov
Copy link

codecov bot commented Mar 1, 2020

Codecov Report

Merging #5371 into master will increase coverage by 19.75%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5371       +/-   ##
===========================================
+ Coverage   17.51%   37.26%   +19.75%     
===========================================
  Files         700       60      -640     
  Lines       10330     1959     -8371     
  Branches     1687      440     -1247     
===========================================
- Hits         1809      730     -1079     
+ Misses       7089      916     -6173     
+ Partials     1432      313     -1119     
Flag Coverage Δ
#front ?
#unit 37.26% <0.00%> (-0.04%) ⬇️
Impacted Files Coverage Δ
packages/strapi-plugin-graphql/services/utils.js 34.14% <0.00%> (-1.76%) ⬇️
...rapi-admin/admin/src/contexts/MarketPlace/index.js
...permissions/admin/src/components/EditForm/index.js
.../strapi-plugin-documentation/admin/src/pluginId.js
...rmissions/admin/src/containers/EditPage/reducer.js
...in-upload/admin/src/components/FileIcon/Wrapper.js
...admin/src/components/DraggedField/RemoveWrapper.js
...ype-builder/admin/src/containers/ListView/index.js
...ntation/admin/src/containers/HomePage/constants.js
...permissions/admin/src/components/Policies/index.js
... and 630 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3be5e...585541a. Read the comment docs.

@alexandrebodin
Copy link
Member

This callback should also be removed from the email.send service in the email plugin :)

@dacre-denny
Copy link
Contributor Author

This callback should also be removed from the email.send service in the email plugin :)

Just had a look and as you mentioned, it does appear to be redundant as well :)
#5466

@alexandrebodin
Copy link
Member

@dacre-denny Can you please make your changes in one single PR :)

@dacre-denny
Copy link
Contributor Author

@alexandrebodin sorry for the delay - found a few more redundant cb, so I've zapped those as well :)

@alexandrebodin
Copy link
Member

@dacre-denny great :) can you fix the DCO check so your PR is mergeable ;)

alexandrebodin
alexandrebodin previously approved these changes Mar 20, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks 💯

@alexandrebodin
Copy link
Member

@dacre-denny waiting on the DCO check to pass before merging.

@alexandrebodin alexandrebodin added source: core:email Source is core/email package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 20, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 20, 2020
@dacre-denny dacre-denny force-pushed the patch-1 branch 2 times, most recently from e1c17e1 to 07d4974 Compare March 20, 2020 10:14
…l providers

Signed-off-by: dacre-denny <dacre@mooce.co.nz>
@alexandrebodin alexandrebodin merged commit 45d83ea into strapi:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:email Source is core/email package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants