New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed redundant callback argument #5371
Conversation
This callback should also be removed from the email.send service in the email plugin :) |
Just had a look and as you mentioned, it does appear to be redundant as well :) |
@dacre-denny Can you please make your changes in one single PR :) |
@alexandrebodin sorry for the delay - found a few more redundant |
@dacre-denny great :) can you fix the DCO check so your PR is mergeable ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks 💯
@dacre-denny waiting on the DCO check to pass before merging. |
e1c17e1
to
07d4974
Compare
…l providers Signed-off-by: dacre-denny <dacre@mooce.co.nz>
The
cb
argument is not used in thesend
method and was therefore removed. Ready for merge.