Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typo fixes #5407

Merged
merged 8 commits into from Mar 12, 2020
Merged

Minor typo fixes #5407

merged 8 commits into from Mar 12, 2020

Conversation

ScottAgirs
Copy link
Contributor

Description of what you did:

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #5407 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5407   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10151           
  Branches     1643     1643           
=======================================
  Hits         1800     1800           
  Misses       6961     6961           
  Partials     1390     1390           
Flag Coverage Δ
#front 13.14% <ø> (ø)
#unit 37.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b50b04...ac13642. Read the comment docs.

@lauriejim lauriejim added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 5, 2020
@lauriejim
Copy link
Contributor

Hello! Thank you for this PR, can you please valid the DCO please:

https://github.com/strapi/strapi/pull/5407/checks?check_run_id=485117163

ScottAgirs and others added 2 commits March 5, 2020 11:40
convetion > convetion

Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: ScottAgirs <scott@ijs.to>
Signed-off-by: ScottAgirs <scott@ijs.to>
…atch-1

Signed-off-by: ScottAgirs <scott@ijs.to>
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 12, 2020
@alexandrebodin alexandrebodin merged commit 1a86d43 into strapi:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants