Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #5426

Merged
merged 1 commit into from Mar 12, 2020
Merged

fix typo #5426

merged 1 commit into from Mar 12, 2020

Conversation

nazrdogan
Copy link
Contributor

@nazrdogan nazrdogan commented Mar 5, 2020 •
edited

fixed typo

@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited

Codecov Report

Merging #5426 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5426   +/-   ##
=======================================
  Coverage   17.74%   17.74%           
=======================================
  Files         687      687           
  Lines       10150    10150           
  Branches     1643     1643           
=======================================
  Hits         1801     1801           
  Misses       6959     6959           
  Partials     1390     1390
Flag Coverage Δ
#front 13.15% <ø> (ø)
#unit 37.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d6a34...d29b5e6. Read the comment docs.

@lauriejim
Copy link
Contributor

Ooups! Thank you for this fix! Can you please check the DCO : https://github.com/strapi/strapi/pull/5426/checks?check_run_id=487442463
Then I will merge your PR

@lauriejim lauriejim added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 5, 2020
@nazrdogan
fix typo
666b3c6 
Signed-off-by: Nazir Dogan <nazrdogan@gmail.com>
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 12, 2020
alexandrebodin
alexandrebodin approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks !

@alexandrebodin alexandrebodin merged commit a13b7b0 into strapi:master Mar 12, 2020
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2022
Open
@ryanmanns-ix ryanmanns-ix mentioned this pull request Jun 21, 2022
Open
@songshansitulv songshansitulv mentioned this pull request Jun 21, 2022
Open
@sparkbold sparkbold mentioned this pull request Jun 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 22, 2022
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@ryanmanns-ix ryanmanns-ix mentioned this pull request Nov 25, 2023
Open
@songshansitulv songshansitulv mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandrebodin alexandrebodin alexandrebodin approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Milestone
3.0.0-beta.19.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nazrdogan @lauriejim @alexandrebodin