Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: short relation fields list have unnecessary scrollbar #5438

Merged
merged 2 commits into from Mar 27, 2020
Merged

fix: short relation fields list have unnecessary scrollbar #5438

merged 2 commits into from Mar 27, 2020

Conversation

wysher
Copy link
Contributor

@wysher wysher commented Mar 5, 2020

Description of what you did:

My yesterday's PR had small flaw - for short relation fields scroll still is visible. Sorry for that.
This PR fixes it.

screenshots

before:
relation-list-scroll-before

after:
relation-list-scroll-after

@wysher
fix: short relation fields list have unnecessary scrollbar
5ca3704 
Signed-off-by: Mariusz Wachowski <wachowski.mariusz@gmail.com>
@wysher wysher force-pushed the fix/relation-list-unnecessary-scroll branch from 7ba897d to 5ca3704 Compare March 5, 2020 19:28
@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited

Codecov Report

Merging #5438 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5438   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10151           
  Branches     1643     1643           
=======================================
  Hits         1800     1800           
  Misses       6961     6961           
  Partials     1390     1390
Flag Coverage Δ
#front 13.14% <ø> (ø)
#unit 37.04% <ø> (ø)
Impacted Files Coverage Δ
...ager/admin/src/components/SelectMany/components.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b93599...854d84a. Read the comment docs.

soupette
soupette approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 9, 2020
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 9, 2020
@alexandrebodin alexandrebodin merged commit b96ed62 into strapi:master Mar 27, 2020
@snyk-bot snyk-bot mentioned this pull request Jun 21, 2022
Open
@ryanmanns-ix ryanmanns-ix mentioned this pull request Jun 21, 2022
Open
@songshansitulv songshansitulv mentioned this pull request Jun 21, 2022
Open
@sparkbold sparkbold mentioned this pull request Jun 21, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 22, 2022
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@ryanmanns-ix ryanmanns-ix mentioned this pull request Nov 25, 2023
Open
@songshansitulv songshansitulv mentioned this pull request Nov 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soupette soupette soupette approved these changes

Assignees
No one assigned
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:content-manager Source is core/content-manager package
Projects
None yet
Milestone
3.0.0-beta.19.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wysher @soupette @alexandrebodin