Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count GraphQL guide #5447

Merged
merged 3 commits into from Mar 9, 2020
Merged

Add count GraphQL guide #5447

merged 3 commits into from Mar 9, 2020

Conversation

lauriejim
Copy link
Contributor

Description of what you did:

This PR adds a Guide to the docs.
Some people from the community asked about count function in GraphQL.
Aggregation is not working well and is not available for every database, this guide let you understand how to add custom GraphQL query, in this case, a count query.

Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
@lauriejim lauriejim added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Mar 6, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor stuff

docs/3.0.0-beta.x/guides/count-graphql.md Outdated Show resolved Hide resolved
docs/3.0.0-beta.x/guides/count-graphql.md Outdated Show resolved Hide resolved
@derrickmehaffy derrickmehaffy self-requested a review March 6, 2020 14:48
@derrickmehaffy
Copy link
Member

derrickmehaffy commented Mar 6, 2020

Would this not just be easier to add to the default schema until aggregations can be reviewed?

Else a user would need to duplicate this same thing for every single model

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #5447 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5447   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10151           
  Branches     1643     1643           
=======================================
  Hits         1800     1800           
  Misses       6961     6961           
  Partials     1390     1390           
Flag Coverage Δ
#front 13.14% <ø> (ø)
#unit 37.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a8929e...9ab7144. Read the comment docs.

@alexandrebodin
Copy link
Member

@derrickmehaffy that basically means starting implementing aggregations in bookshelf :D
We should start working on it "soon"

@derrickmehaffy
Copy link
Member

@derrickmehaffy that basically means starting implementing aggregations in bookshelf :D
We should start working on it "soon"

I mean in this case just handling count since it's just a basic one that's calling the service but I do see your point. (In my case I just handle this in a header on all requests so I don't have to manually call counts)

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy requested review from alexandrebodin and removed request for derrickmehaffy March 6, 2020 18:25
@derrickmehaffy
Copy link
Member

@lauriejim fixed the PR feedback for you with a few other changes.

@alexandrebodin
Copy link
Member

@derrickmehaffy that basically means starting implementing aggregations in bookshelf :D
We should start working on it "soon"

I mean in this case just handling count since it's just a basic one that's calling the service but I do see your point. (In my case I just handle this in a header on all requests so I don't have to manually call counts)

Yes we really need to introduce real pagination :)

@derrickmehaffy
Copy link
Member

@derrickmehaffy that basically means starting implementing aggregations in bookshelf :D
We should start working on it "soon"

I mean in this case just handling count since it's just a basic one that's calling the service but I do see your point. (In my case I just handle this in a header on all requests so I don't have to manually call counts)

Yes we really need to introduce real pagination :)

Yup still got that discussion issue open about that and other parameters 😉

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 9, 2020
@alexandrebodin alexandrebodin merged commit 4b93599 into master Mar 9, 2020
@alexandrebodin alexandrebodin deleted the docs-guide-count-graphql branch March 9, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants