New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add count GraphQL guide #5447
Add count GraphQL guide #5447
Conversation
Signed-off-by: Jim LAURIE <j.laurie6993@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor stuff
Would this not just be easier to add to the default schema until aggregations can be reviewed? Else a user would need to duplicate this same thing for every single model |
Codecov Report
@@ Coverage Diff @@
## master #5447 +/- ##
=======================================
Coverage 17.73% 17.73%
=======================================
Files 687 687
Lines 10151 10151
Branches 1643 1643
=======================================
Hits 1800 1800
Misses 6961 6961
Partials 1390 1390
Continue to review full report at Codecov.
|
@derrickmehaffy that basically means starting implementing aggregations in bookshelf :D |
I mean in this case just handling count since it's just a basic one that's calling the service but I do see your point. (In my case I just handle this in a header on all requests so I don't have to manually call counts) |
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@lauriejim fixed the PR feedback for you with a few other changes. |
Yes we really need to introduce real pagination :) |
Yup still got that discussion issue open about that and other parameters 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of what you did:
This PR adds a Guide to the docs.
Some people from the community asked about
count
function in GraphQL.Aggregation is not working well and is not available for every database, this guide let you understand how to add custom GraphQL query, in this case, a
count
query.