Display version from package.json in left menu #5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…back-end Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette
requested review from
HichamELBSI and
alexandrebodin
and removed request for
HichamELBSI
soupette
added
source: core:admin
|
It would be cool to add a warning by comparing the data you get from the getEnv and the built version with this change. |
Codecov Report
@@ Coverage Diff @@
## master #5478 +/- ##
=======================================
Coverage 17.73% 17.73%
=======================================
Files 687 687
Lines 10151 10154 +3
Branches 1643 1644 +1
=======================================
+ Hits 1800 1801 +1
- Misses 6961 6962 +1
- Partials 1390 1391 +1
Continue to review full report at Codecov.
|
| @@ -1,5 +1,6 @@ | |||
| // Shared constants | |||
| import { fromJS } from 'immutable'; | |||
| import packageJSON from '../../../../package.json'; | |||
There was a problem hiding this comment.
I think this will break because we do not copy the pkg.json file in the .cache folder :/
Signed-off-by: soupette <cyril.lpz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what you did:
This PR uses the version from the
package.jsonto display thebuiltversion in the left menu. This PR will let users know if they have updated their administration panel correctly.