Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic zone reorder input file and date updates #5488

Merged
merged 6 commits into from Mar 12, 2020
Merged

Conversation

soupette
Copy link
Contributor

@soupette soupette commented Mar 10, 2020

Signed-off-by: soupette cyril.lpz@gmail.com

Description of what you did:

This PR fixes the input file and date reordering issue in the content manager

Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette marked this pull request as ready for review March 10, 2020 16:55
@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #5488 into master will decrease coverage by 0.28%.
The diff coverage is 0.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5488      +/-   ##
==========================================
- Coverage   17.73%   17.44%   -0.29%     
==========================================
  Files         687      699      +12     
  Lines       10151    10322     +171     
  Branches     1643     1685      +42     
==========================================
+ Hits         1800     1801       +1     
- Misses       6961     7089     +128     
- Partials     1390     1432      +42     
Flag Coverage Δ
#front 12.88% <0.57%> (-0.26%) ⬇️
#unit 37.04% <ø> (ø)
Impacted Files Coverage Δ
...nents/InputFileWithErrors/ImgPreview/IconUpload.js 0.00% <0.00%> (ø)
...mponents/InputFileWithErrors/ImgPreview/Wrapper.js 0.00% <0.00%> (ø)
...components/InputFileWithErrors/ImgPreview/index.js 0.00% <0.00%> (ø)
...nts/InputFileWithErrors/ImgPreviewArrow/Wrapper.js 0.00% <0.00%> (ø)
...nents/InputFileWithErrors/ImgPreviewArrow/index.js 0.00% <0.00%> (ø)
...components/InputFileWithErrors/ImgPreviewHint/P.js 0.00% <0.00%> (ø)
...onents/InputFileWithErrors/ImgPreviewHint/index.js 0.00% <0.00%> (ø)
...in/src/components/InputFileWithErrors/InputFile.js 0.00% <ø> (ø)
...putFileWithErrors/InputFileDetails/EmptyWrapper.js 0.00% <0.00%> (ø)
...ts/InputFileWithErrors/InputFileDetails/Wrapper.js 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5ba26...cba1d69. Read the comment docs.

@soupette soupette changed the title Fix DZ input file and date updates Fix dynamic zone reorder input file and date updates Mar 10, 2020
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette merged commit eb9a4d6 into master Mar 12, 2020
@soupette soupette deleted the fix/dz branch March 12, 2020 16:44
@soupette soupette added this to the 3.0.0-beta.19.4 milestone Mar 12, 2020
@soupette soupette added source: core:content-manager Source is core/content-manager package issue: bug Issue reporting a bug labels Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants