Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DigitalOcean one-click docs for recent changes #5493

Merged
merged 2 commits into from Mar 13, 2020

Conversation

derrickmehaffy
Copy link
Member

Description of what you did:

Per PR strapi/one-click-deploy#6 there will be some changes, please don't merge until after me and @pierreburgy have talked with DigitalOcean about changing the image for the marketplace.

@derrickmehaffy derrickmehaffy requested review from pierreburgy, alexandrebodin and lauriejim and removed request for alexandrebodin March 12, 2020 08:56
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5493 into master will increase coverage by 19.85%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5493       +/-   ##
===========================================
+ Coverage   17.44%   37.30%   +19.85%     
===========================================
  Files         699       60      -639     
  Lines       10322     1957     -8365     
  Branches     1685      439     -1246     
===========================================
- Hits         1801      730     -1071     
+ Misses       7089      915     -6174     
+ Partials     1432      312     -1120     
Flag Coverage Δ
#front ?
#unit 37.30% <66.66%> (+0.25%) ⬆️
Impacted Files Coverage Δ
packages/strapi/lib/core-api/controller.js 23.07% <0.00%> (ø)
packages/strapi-database/lib/utils/primary-key.js 100.00% <100.00%> (ø)
...uilder/admin/src/components/WrapperSelect/index.js
.../admin/src/components/SettingsViewWrapper/index.js
...ugin-documentation/admin/src/translations/index.js
.../strapi-admin/admin/src/components/Header/index.js
...content-manager/admin/src/icons/Underline/index.js
...ugin-email/admin/src/containers/ConfigPage/saga.js
...admin/admin/src/containers/AuthPage/CustomLabel.js
...src/components/LeftMenuLink/LeftMenuLinkContent.js
... and 633 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310fc3d...7f87d86. Read the comment docs.

@lauriejim
Copy link
Contributor

Okay, so @pierreburgy you manage the approval and merge of this PR, please.
Just ping me on Slack when it's done.
Thank you.

pierreburgy
pierreburgy previously approved these changes Mar 12, 2020
Copy link
Member

@pierreburgy pierreburgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@derrickmehaffy
Copy link
Member Author

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Copy link
Contributor

@lauriejim lauriejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauriejim lauriejim merged commit 875432c into master Mar 13, 2020
@lauriejim lauriejim deleted the docs/do-one-click branch March 13, 2020 13:32
@lauriejim lauriejim added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 13, 2020
@lauriejim lauriejim added this to the 3.0.0-beta.19.4 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants