Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to set a relation "private" #5494

Merged
merged 2 commits into from Mar 13, 2020

Conversation

petersg83
Copy link
Contributor

fix #4653

Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5494 into master will increase coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5494   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10154    +3     
  Branches     1643     1644    +1     
=======================================
+ Hits         1800     1801    +1     
- Misses       6961     6962    +1     
- Partials     1390     1391    +1     
Flag Coverage Δ
#front 13.15% <20.00%> (+<0.01%) ⬆️
#unit 37.04% <0.00%> (ø)
Impacted Files Coverage Δ
...t-type-builder/controllers/validation/relations.js 62.50% <ø> (ø)
...tent-type-builder/services/schema-builder/index.js 12.50% <0.00%> (ø)
...s/strapi-admin/admin/src/containers/App/reducer.js 60.00% <20.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b1b30...60da8cd. Read the comment docs.

Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package issue: bug Issue reporting a bug labels Mar 13, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 13, 2020
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexandrebodin alexandrebodin merged commit 1227bfe into master Mar 13, 2020
@alexandrebodin alexandrebodin deleted the fix/#4653/errorPrivateFieldGraphQl branch March 13, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: plugin:graphql Source is plugin/graphql package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL fails when relation field is set to private
2 participants