Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error message when bookshelf db connection fails at start #5499

Conversation

petersg83
Copy link
Contributor

fix #4589

Signed-off-by: Pierre Noël <pierre.noel@strapi.io>
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #5499 into master will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5499   +/-   ##
=======================================
  Coverage   17.73%   17.73%           
=======================================
  Files         687      687           
  Lines       10151    10154    +3     
  Branches     1643     1644    +1     
=======================================
+ Hits         1800     1801    +1     
- Misses       6961     6962    +1     
- Partials     1390     1391    +1     
Flag Coverage Δ
#front 13.15% <20.00%> (+<0.01%) ⬆️
#unit 37.04% <ø> (ø)
Impacted Files Coverage Δ
...s/strapi-admin/admin/src/containers/App/reducer.js 60.00% <20.00%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5ba26...d74bb66. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Nice job

@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 13, 2020
@alexandrebodin alexandrebodin added source: core:database Source is core/database package issue: bug Issue reporting a bug labels Mar 13, 2020
@alexandrebodin alexandrebodin merged commit 65a3e83 into master Mar 13, 2020
@alexandrebodin alexandrebodin deleted the fix/#4589/betterErrorMessageWhenDBConnectionFailsAtStartup branch March 13, 2020 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong error in startup when no database is running
2 participants