Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix little syntax error #5516

Merged
merged 3 commits into from Mar 20, 2020
Merged

Fix little syntax error #5516

merged 3 commits into from Mar 20, 2020

Conversation

NikolasMelui
Copy link
Contributor

  • Update the documentation:

Find little syntax error and fix it.

@alexandrebodin
Copy link
Member

Hi @NikolasMelui the DCO check isn't passing on your PR ;)

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #5516 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5516   +/-   ##
=======================================
  Coverage   17.51%   17.51%           
=======================================
  Files         700      700           
  Lines       10330    10330           
  Branches     1687     1687           
=======================================
  Hits         1809     1809           
  Misses       7089     7089           
  Partials     1432     1432           
Flag Coverage Δ
#front 12.88% <ø> (ø)
#unit 37.30% <ø> (ø)
Impacted Files Coverage Δ
...pe-builder/admin/src/components/ListRow/Wrapper.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac1898e...1a3f1fb. Read the comment docs.

@NikolasMelui
Copy link
Contributor Author

Hi @NikolasMelui the DCO check isn't passing on your PR ;)

Yeap, sorry for that! Will fix it as fast as possible ;D

@alexandrebodin alexandrebodin self-requested a review March 20, 2020 13:45
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Mar 20, 2020
@alexandrebodin alexandrebodin added this to the 3.0.0-beta.19.4 milestone Mar 20, 2020
@alexandrebodin alexandrebodin merged commit a74239c into strapi:master Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants